ingress: remove unused annotations #30733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/cleanup
sayboras
approved these changes
Feb 21, 2024
The following Ingress annotations aren't actually used by any Ingress related logic. - `ingress.cilium.io/tcp-keep-alive` - `ingress.cilium.io/tcp-keep-alive-idle` - `ingress.cilium.io/tcp-keep-probe-interval` - `ingress.cilium.io/tcp-keep-probe-max-failures` - `ingress.cilium.io/websocket` Support has been removed with cilium#21386, while introducing the shared loadbalancer support. Therefore, this commit uses the unused annotations and their functionality. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/ingress-rem-tcp-keep-alive-annos
branch
from
221a183
to
7da2c00
Compare
|
/test |
youngnick
approved these changes
Feb 21, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
mhofstetter
deleted the
pr/mhofstetter/ingress-rem-tcp-keep-alive-annos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following Ingress annotations aren't actually used by any Ingress related logic.
ingress.cilium.io/tcp-keep-aliveingress.cilium.io/tcp-keep-alive-idleingress.cilium.io/tcp-keep-probe-intervalingress.cilium.io/tcp-keep-probe-max-failuresingress.cilium.io/websocketSupport has been removed with #21386, while introducing the shared loadbalancer support.
It looks like the current logic only uses hard-coded defaults for these values: https://github.com/cilium/cilium/blob/main/operator/pkg/model/translation/envoy_listener.go#L103-L112
IMO we should remove the unused annotations and their functionality or add back the support for these annotations.