Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indexing of routes #30762

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fix indexing of routes #30762

merged 3 commits into from
Feb 14, 2024

Commits on Feb 14, 2024

  1. devices: Expand test to check route table 

    Issue #30563 showed that veth devices were picked as selected
native devices even though they did not have a route. This was
due to a bug in the route StateDB table indexing. This commit
expands the devices controller tests to catch this wrong
behavior.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
    @joamaki @dylandreimerink
    joamaki authored and dylandreimerink committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fe35e61 View commit details
    Browse the repository at this point in the history

  2. datapath/tables: Fix the primary indexer for routes 

    The RouteID.Key() was supposed to make a composite key from
'table + index + destination', but due to a copy-paste
brainfart the composite index was 'table + table + destination'.

Fix Key() to correctly build the key. While at it, make it more
efficient by pre-allocating the correct fixed-size byte slice.

Fixes: #30563
Fixes: 8abf620 ("devices_controller: Switched devices and routes from StateDB to StateDB2")
Signed-off-by: Jussi Maki <jussi@isovalent.com>
    @joamaki @dylandreimerink
    joamaki authored and dylandreimerink committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    07a8eca View commit details
    Browse the repository at this point in the history

  3. conformance-e2e: Explicitly set devices to fix e2e tests 

    We are failing a e2e test quite consistantly, while the root cause is
not fully clear, it seems that setting devices explicitly might help.

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
    @dylandreimerink
    dylandreimerink committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1cc99e8 View commit details
    Browse the repository at this point in the history