Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enhance test execution security by restricting permissions to the 'organization-members' team #30790

Merged
merged 1 commit into from Feb 18, 2024

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Feb 15, 2024

This PR updates the Ariane configuration to include the GitHub organization team 'organization-members' in the list of allowed teams. Consequently, only members of this specific team will have the authorization to initiate test runs via issue comments.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 15, 2024
@brlbil brlbil added the release-note/ci This PR makes changes to the CI. label Feb 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 15, 2024
@brlbil brlbil added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.7 Feb 15, 2024
@brlbil
Copy link
Contributor Author

brlbil commented Feb 15, 2024

/test

@brlbil brlbil marked this pull request as ready for review February 15, 2024 08:10
@brlbil brlbil requested a review from a team as a code owner February 15, 2024 08:10
@brlbil brlbil force-pushed the pr/brlbil/ci-add-allowed-teams branch from 0c0bc9e to ce9e932 Compare February 16, 2024 16:14
@brlbil brlbil requested review from a team as code owners February 16, 2024 16:14
@brlbil brlbil requested review from viktor-kurchenko and removed request for a team and aditighag February 16, 2024 16:14
@brlbil
Copy link
Contributor Author

brlbil commented Feb 16, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Feb 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.8 Feb 16, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.13 Feb 16, 2024
@sayboras
Copy link
Member

sayboras commented Feb 17, 2024

Can you fix the checkpatch validation? Ah this seems to be optional check.

Error: ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 97)

@brlbil brlbil force-pushed the pr/brlbil/ci-add-allowed-teams branch 2 times, most recently from a89c437 to f163d71 Compare February 18, 2024 08:42
This commit updates the Ariane configuration to include the GitHub organization team 'organization-members' in the list of allowed teams.
Consequently, only members of this specific team will have the authorization to initiate test runs via issue comments.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-add-allowed-teams branch from f163d71 to 267bc33 Compare February 18, 2024 10:56
@brlbil
Copy link
Contributor Author

brlbil commented Feb 18, 2024

/test

@aanm aanm deleted the pr/brlbil/ci-add-allowed-teams branch February 18, 2024 15:17
@tklauser tklauser mentioned this pull request Feb 20, 2024
7 tasks
@tklauser tklauser added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 20, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Feb 20, 2024
@tklauser tklauser mentioned this pull request Feb 20, 2024
6 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Feb 20, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.8 Feb 20, 2024
@tklauser tklauser mentioned this pull request Feb 20, 2024
5 tasks
@tklauser tklauser added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Feb 20, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.13 Feb 20, 2024
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Feb 20, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.13 in 1.13.13 Feb 20, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Feb 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.8 Feb 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.13 in 1.13.13 Feb 21, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.14 in 1.14.8 Feb 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Backport done to v1.15 in 1.15.2 Feb 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport done to v1.15 in 1.15.2 Feb 21, 2024
@aanm aanm moved this from Needs backport from main to Backport done to v1.14 in 1.14.7 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.13
Backport done to v1.13
1.14.7
Backport done to v1.14
1.14.8
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

5 participants