Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: Remove or downgrade noisy logs #30868

Merged
merged 6 commits into from
Feb 22, 2024
Merged

bgpv1: Remove or downgrade noisy logs #30868

merged 6 commits into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. bgpv1: Remove a noisy log in Controller 

    Controller generate a log for every single reconciliation. This is noisy
and doesn't make much sense since users doesn't care about
reconciliation happening, but the outcome of the reconciliation.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
    @YutaroHayakawa
    YutaroHayakawa committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8c53896 View commit details
    Browse the repository at this point in the history

  2. bgpv1: Inform when the node is not selected anymore 

    When users stop selecting the node with CiliumBGPPeeringPolicy, BGP
Control Plane removes all running virtual router instances. However, it
is only notified with Debug level. Upgrade it to Info level since this
is an important information which helps users to investigate session
disruption with configuration miss.

Also, the log is generated and full reconciliation happens even if there
is no previous policy applied. This means when there's no policy applied
and any relevant resource (e.g. Service) is updated, it will generate
the log and does full withdrawal meaninglessly. Introduce a flag that
indicates whether there is a previous policy and conditionally trigger
log generation and full withdrawal.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
    @YutaroHayakawa
    YutaroHayakawa committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    891ce22 View commit details
    Browse the repository at this point in the history

  3. bgpv1: Remove noisy logs from neighbor reconciler 

    Remove noisy logs generated for every single reconciliation.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
    @YutaroHayakawa
    YutaroHayakawa committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d8acf7a View commit details
    Browse the repository at this point in the history

  4. bgpv1: Remove unnecessary stat logs from neighbor reconciler 

    We don't need to show create/update/delete counts because we show logs
for all create/update/delete operation anyways.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
    @YutaroHayakawa
    YutaroHayakawa committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4b5693b View commit details
    Browse the repository at this point in the history

  5. bgpv1: Remove noisy log from route policy reconciler 

    Remove a noisy log which will be generated for every single
reconciliation from route policy reconciler.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
    @YutaroHayakawa
    YutaroHayakawa committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    106cee8 View commit details
    Browse the repository at this point in the history

  6. bgpv1: Downgrade peer state transition logs to Debug 

    Users can now easily check the current peering state with `cilium bgp
peers` command. Thus state transition logs become relatively unimportant
for users. Downgrade the logs to debug level.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
    @YutaroHayakawa
    YutaroHayakawa committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0db49df View commit details
    Browse the repository at this point in the history