Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.14 Author backport of #29162 #30882

Merged
merged 1 commit into from
Feb 21, 2024

Commits on Feb 21, 2024

  1. policy: Only record an old entry if needed

    [ upstream commit 9916824 ]
    
    Only record an old entry in ChangeState if it existed before this round
    of changes. We do this by testing if the entry is already in Adds. If
    not, then we record the old entry key and value. If the Adds entry
    exists, however, this entry may have only been added on this round of
    changes and we do not record the old value. This is safe due to the fact
    that when the Adds entry is created, the Old value is stored before
    adding the Adds entry, so for the first Adds entry the Old value does not
    yet exist and will be added.
    
    This removes extraneous Old entries that did not actually originally
    exist. Before this ChangeState.Revert did restore an entry the should not
    exists based on these extraneous Old entries.
    
    Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
    jrajahalme committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    49c8df6 View commit details
    Browse the repository at this point in the history