Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/endpoint: remove reserved:init from endpoints #30909

Merged
merged 1 commit into from Feb 27, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Feb 22, 2024

Previously, a bug introduced in e43b759 caused the 'reserved:init' label to persist even after an endpoint received its security identity labels. This resulted in endpoints being unable to send or receive any network traffic. This fix ensures that the 'reserved:init' label is properly removed once initialization is complete.

Fixes: e43b759 ("pkg/endpoint: keep endpoint labels for their original sources")

Fix bug prevented endpoints from sending or receiving network traffic due to the 'reserved:init' label persisting after initialization.

Fixes #30524

Previously, a bug introduced in e43b759 caused the 'reserved:init'
label to persist even after an endpoint received its security identity
labels. This resulted in endpoints being unable to send or receive any
network traffic. This fix ensures that the 'reserved:init' label is
properly removed once initialization is complete.

Fixes: e43b759 ("pkg/endpoint: keep endpoint labels for their original sources")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch affects/v1.15 This issue affects v1.15 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Feb 22, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.8 Feb 22, 2024
@aanm
Copy link
Member Author

aanm commented Feb 22, 2024

/test

@aanm aanm marked this pull request as ready for review February 22, 2024 16:59
@aanm aanm requested a review from a team as a code owner February 22, 2024 16:59
@aanm aanm enabled auto-merge February 22, 2024 16:59
@aanm aanm added this pull request to the merge queue Feb 27, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 27, 2024
Merged via the queue into cilium:main with commit 9620979 Feb 27, 2024
63 checks passed
@aanm aanm deleted the pr/fix-reserved-init branch February 27, 2024 23:20
@YutaroHayakawa YutaroHayakawa mentioned this pull request Feb 29, 2024
2 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Feb 29, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request Feb 29, 2024
2 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.8 Feb 29, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 1, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.2 Mar 1, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Mar 1, 2024
@thorn3r thorn3r moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.8 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch affects/v1.15 This issue affects v1.15 branch backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.14.8
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

Cilium 1.14.5+ can break Kubernetes pod connectivity due to the reserved:init label never being removed
3 participants