Centralize configuration of kind version/image in GitHub Action workflows #30916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
|
/test |
giorio94
force-pushed
the
pr/giorio94/main/centralize-kind-image-definition
branch
from
07682e8
to
eb106cf
Compare
giorio94
added
backport/author
giorio94
force-pushed
the
pr/giorio94/main/centralize-kind-image-definition
branch
2 times, most recently
from
7822bc7
to
a5d74aa
Compare
giorio94
requested review from
youngnick,
aanm,
viktor-kurchenko,
pchaigno and
YutaroHayakawa
|
/ci-e2e-upgrade |
|
Converting back to draft. The image seems not to be correctly picked by LVH-based workflows. |
Let's define kind-related variables (i.e., version, k8s image and k8s version) inside the set-env-variables action. One all consumers will have been migrated through the subsequent commit, this will ensure consistency across workflows, simplify version bumps as well as the introduction of new workflows depending on them. One extra byproduct is that renovate updates will also stop requesting reviews from all the different teams owning each specific workflow. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
backport-pending/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.2
giorio94
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.8
giorio94
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.13
github-actions
bot
added
backport-done/1.15
jrajahalme
moved this from Backport pending to v1.15
to Backport done to v1.15
in 1.15.3
jrajahalme
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's define kind-related variables (i.e., version, k8s image and k8s version) inside the set-env-variables action. This ensures consistency across workflows, simplify version bumps as well as the introduction of new workflows depending on them. One extra byproduct is that renovate updates will also stop requesting reviews from all the different teams owning each specific workflow. Additionally, let's also stop waiting for kind clusters to become ready, as they will never, because no CNI is present at that point.
Note: a few pull-request based workflows are currently failing, because they use the
set-env-variableschecked out from the main branch, which doesn't contain the additional variables. This will be fixed after merging this PR.