Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fqdn: avoid expensive sort/unique of names during GC #30920

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fqdn: avoid expensive sort/unique of names during GC #30920

merged 1 commit into from
Mar 15, 2024

Commits on Mar 13, 2024

  1. fqdn: avoid expensive sort/unique of names during GC 

    Return the names affected by GC in a set instead of a slice. This avoids
having to repeatedly sort and unique the slice which is a potentially
expensive operation if there are many FQDN names to garbage collect. The
consumer in `(*NameManager).GC` will expect a `sets.Set` already anyway.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
    @tklauser
    tklauser committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    16caf0e View commit details
    Browse the repository at this point in the history