StateDB based Health #30925
Merged
StateDB based Health #30925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tommyp1ckles
force-pushed
the
pr/tp/healthv2
branch
5 times, most recently
from
0bd731f
to
6ab23b5
Compare
tommyp1ckles
requested review from
sayboras,
dylandreimerink,
learnitall and
joamaki
tommyp1ckles
force-pushed
the
pr/tp/healthv2
branch
2 times, most recently
from
c9b14dc
to
a512295
Compare
learnitall
requested changes
Feb 26, 2024
tommyp1ckles
force-pushed
the
pr/tp/healthv2
branch
6 times, most recently
from
6c1b0ae
to
f7ea5e0
Compare
|
/test |
The 'cilium status' cli output now uses the statedb remote table endpoint to fetch health data Thus we can remove the old module health specific code and openapi schema. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Some code will remain as it is used for testing in other places. We will remove this once we have switched completely to healthv2. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Adds codeowners entry for healthv2. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
operator/pkg/bgpv2 relies on having a health provider. This adds a healthv2, as well as its dependency statedb to fix operator hive. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
This fixes test failures in statedb/reconciler, this also replaces usingt the to json hack used in the previous health implementation. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Sets up hive fixture then queries statedb table directly to check that expected updates occurred Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/healthv2
branch
from
ff22b3b
to
8e037e2
Compare
|
/test |
qmonnet
requested changes
Apr 8, 2024
qmonnet
added
area/cli
Do to the change of health provider backend, there are some changes to how data is displayed that may be relevant to users upgrading to v1.16. As well, health status data is now strictly sorted by the fully qualified health status identifier (i.e. [fq-module-id].[fq-component-id]). Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
|
/test |
derailed
approved these changes
Apr 8, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
lmb
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
healthv2: add new module health implementation based on statedb.
Similar to existing implementation in hive/cell/<health/structured>.go, this provides system health data in a tree structure.
However, this seeks to reimplement the health provider such that it is no longer coupled to pkg/hive/cell.
Because this will eventually be run just as any other Agent module, we can use StateDB for the implementation.
For more information about the original tree structured health reporter take a look at code documentation here. This seeks to provide a similar underlying structure of data while using a much simpler statedb schema.
Note: The only intended user impact of these changes is that health data will now be available with
cilium-dbg statedb healthandcilium-dbg statedb dump.This massively reduces the complexity of the health implementation, as well as provides a more convenient data model for storing health update data.
Furthermore, this fixes the awkward distinction between "module" and "subcomponent" reporting by unifying how these health reports are stored in one place.
pkg/healthv2/provider.go implements a new health provider that uses statedb to store a table of health updates by their fully qualified identifier. This is composed of:
[module-id].[componenet-id]
Where the module ID is a fully qualified ID of submodules, ex:
i. agent.controlplane.bgpv1
Example
cilium statedb healthoutput:Similarily the component id is a ID representing a tree of subcomponents of a module. Together, these form a tree where each path stores information about the module and component being reported on. As well, Status updates store the original "two-component" identifier.
This schema is meant to be less opinionated about how to view health data, it is simply a set of health report rows indexed by a identifier path.
Because of this, there is no longer any distinction between a "reporter" (i.e. leaf) and "scope" (i.e. parent node). This means that a reporter can have a status and have child reports.
Initially this will be shimmed into the existing health infrastructure in hive/cell. Ultimately we will remove all that code and refactor health reporters using the external github.com/cilium/hive library.