Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.14] Bump envoy to v1.27.x #31007

Merged
merged 2 commits into from Mar 27, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 27, 2024

Once this PR is merged, a GitHub action will update the labels of these PRs:

 27498 31221

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Feb 27, 2024
@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch from 711d50b to 43822a5 Compare February 27, 2024 12:32
@sayboras
Copy link
Member Author

/test-backport-1.14

@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch 4 times, most recently from c0930fa to 18b08d1 Compare March 5, 2024 08:58
@sayboras
Copy link
Member Author

sayboras commented Mar 5, 2024

/test

@sayboras
Copy link
Member Author

sayboras commented Mar 5, 2024

/test-backport-1.14

@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch 4 times, most recently from 11769c4 to d35e784 Compare March 10, 2024 15:04
@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch 3 times, most recently from d63f3a7 to a1347cc Compare March 16, 2024 12:20
@sayboras
Copy link
Member Author

/test-backport-1.14

@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch from a1347cc to 56d9190 Compare March 19, 2024 12:07
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch 2 times, most recently from cd55b80 to 054f516 Compare March 19, 2024 12:33
@sayboras
Copy link
Member Author

/test-backport-1.14

@sayboras sayboras marked this pull request as ready for review March 19, 2024 13:31
@sayboras sayboras requested review from a team as code owners March 19, 2024 13:31
@sayboras sayboras requested a review from borkmann March 19, 2024 13:31
@sayboras sayboras changed the title v1.14 Backport 2024-02-28 [v1.14] Backport 2024-02-28 for Envoy Mar 20, 2024
@sayboras sayboras added release-blocker/1.14 This issue will prevent the release of the next version of Cilium. dont-merge/preview-only Only for preview or testing, don't merge it. labels Mar 20, 2024
@sayboras sayboras changed the title [v1.14] Backport 2024-02-28 for Envoy [v1.14] Bump envoy to v1.27.x Mar 20, 2024
@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Mar 24, 2024
go.mod Outdated Show resolved Hide resolved
@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch from 054f516 to 208dcce Compare March 25, 2024 10:06
@sayboras
Copy link
Member Author

/test-backport-1.14

@sayboras sayboras requested a review from aanm March 25, 2024 10:08
@aanm aanm added dont-merge/preview-only Only for preview or testing, don't merge it. and removed release-blocker/1.14 This issue will prevent the release of the next version of Cilium. labels Mar 25, 2024
[upstream commit 3166f95]

Use cilium-envoy image that drops privileges from the Envoy process
before it starts.

Envoy now needs to be started as `cilium-envoy-starter`, which drops all
privileges before executing `cilium-envoy`.

If `cilium-envoy` is executed directly with any privileges, it will
terminate with the following error message when any Cilium filters are
first configured:

  "[assert failure: get_capabilities(CAP_EFFECTIVE) == 0 &&
   get_capabilities(CAP_PERMITTED) == 0. Details: cilium-envoy
   running with privileges, exiting"

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to pick up the new image with updated golang version, and other
dependency bump.

Related commit: cilium/proxy@99c1c8f
Related build: https://github.com/cilium/proxy/actions/runs/8179378100/job/22365327840

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch from 208dcce to a1e92a2 Compare March 27, 2024 02:22
@sayboras
Copy link
Member Author

/test-backport-1.14

@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Mar 27, 2024
@sayboras sayboras closed this Mar 27, 2024
@sayboras sayboras reopened this Mar 27, 2024
@sayboras sayboras force-pushed the tam/envoy-1.27-drop-priviledges-1.14 branch from a1e92a2 to 96625fe Compare March 27, 2024 02:24
@sayboras
Copy link
Member Author

/test-backport-1.14

@sayboras sayboras removed the request for review from borkmann March 27, 2024 02:32
@squeed squeed merged commit b59fb15 into cilium:v1.14 Mar 27, 2024
58 checks passed
@sayboras sayboras deleted the tam/envoy-1.27-drop-priviledges-1.14 branch March 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants