cni: use default logger with timestamps. #31014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
1 similar comment
|
/test |
tommyp1ckles
added
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
asauber
approved these changes
Mar 1, 2024
Unlike runtime agent/operator logs, CNI logs are just written to disk so we have no way to attach timestamps to them. This makes it harder to debug CNI issues as we have no way to correlate when things happened between Agent logs and CNI events. This switches CNI to use the same default logger, except with timestamps enabled. Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/cni-timestamp-logging
branch
from
e52ee21
to
b2fe069
Compare
|
/test |
asauber
approved these changes
Mar 2, 2024
joamaki
approved these changes
Mar 4, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
needs-backport/1.13
jibi
removed
the
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Needs backport from main
in 1.13.13
jibi
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.8
jibi
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.13
jrajahalme
moved this from Needs backport from main
to Backport done to v1.15
in 1.15.3
jrajahalme
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike runtime agent/operator logs, CNI logs are just written to disk so we have no way to attach timestamps to them. This makes it harder to debug CNI issues as we have no way to correlate when things happened between Agent logs and CNI events (i.e. in sysdumps).
This switches CNI to use the same default logger, except with timestamps enabled.
Related to #30993