daemon: Use LastSuccessInteraction instead of LastInteraction #31019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
tkna
force-pushed
the
fix-last-interaction
branch
from
eaea689
to
bb6303b
Compare
ldelossa
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
requested review from
a team and
squeed
and removed request for
a team
|
/test |
ldelossa
approved these changes
Mar 8, 2024
|
The L4LB is hitting a flake described in #31167. Rebasing onto the lastest main commit should resolve the issue. |
dylandreimerink
added
the
dont-merge/needs-rebase
cilium-agent periodically checks the connectivity to the k8s api-server by "kubernetes" probe. cachedVersion() returns a cached value of the k8s version to the probe if not expired or invalid. The logic for evaluating the validity of the cache is as follows: 1. check if the api-server connectivity is healthy. If the last check was more than k8sMinimumEventHeartbeat(default: 1m) ago, then valid=false is returned. 2. if the api-server connectivity is given, returns valid=false if the last check was more than k8sVersionCheckInterval(default: 15m) ago. 3. otherwise returns the cached value and valid=true. Currently 'k8smetrics.LastInteraction.Time()' is used in the step 1, which is updated periodically regardless of whether the api-server connectivity is alive or not. This commit fixes it to use 'k8smetrics.LastSuccessInteraction.Time()' instead. Signed-off-by: naoki-take <naoki-take@cybozu.co.jp>
auto-merge was automatically disabled
March 19, 2024 06:55
Head branch was pushed to by a user without write access
tkna
force-pushed
the
fix-last-interaction
branch
from
bb6303b
to
040111e
Compare
|
@dylandreimerink Rebased to main. |
dylandreimerink
removed
the
dont-merge/needs-rebase
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium-agent periodically checks the connectivity to the k8s api-server by "kubernetes" probe.
cachedVersion()returns a cached value of the k8s version to the probe if not expired or invalid.The logic for evaluating the validity of the cache is as follows:
k8sMinimumEventHeartbeat(default: 1m) ago, then valid=false is returned.k8sVersionCheckInterval(default: 15m) ago.Currently
k8smetrics.LastInteraction.Time()is used in the step 1, which is updated periodically regardless of whether the api-server connectivity is alive or not. This commit fixes it to usek8smetrics.LastSuccessInteraction.Time()instead.