Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: Correct the null check for GRPRRoute Match #31052

Merged
merged 1 commit into from Feb 29, 2024
Merged

gateway-api: Correct the null check for GRPRRoute Match #31052

merged 1 commit into from Feb 29, 2024

Conversation

sayboras
Copy link
Member

The null check for Method should be before the check for Method.Service to avoid NPE.

@sayboras
gateway-api: Correct the null check for GRPRRoute Match
81f0336 
The null check for Method should be before the check for Method.Service
to avoid NPE.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras requested a review from a team as a code owner February 29, 2024 06:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 29, 2024
@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 29, 2024
@sayboras sayboras added needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch and removed backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Feb 29, 2024
@sayboras
Copy link
Member Author

/test

meyskens
meyskens approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayboras sayboras added this pull request to the merge queue Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 29, 2024
Merged via the queue into cilium:main with commit cd53c4f Feb 29, 2024
63 checks passed
@sayboras sayboras deleted the tam/grpcroute-null-check branch February 29, 2024 09:16
@pippolo84 pippolo84 mentioned this pull request Mar 5, 2024
Merged
13 tasks
@pippolo84 pippolo84 added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Mar 5, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.2 Mar 11, 2024
@marseel marseel mentioned this pull request Mar 11, 2024
Closed
@jrajahalme jrajahalme mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayboras @meyskens @pippolo84