Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway-api: Enable GRPCRoute conformance tests #31055

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 29, 2024

This is mainly to pick up the new GRPC Conformance tests added recently.

Signed-off-by: Tam Mach tam.mach@cilium.io

Note: wait for the upstream PR kubernetes-sigs/gateway-api#2745 ✔️

gateway-api: Enable GRPCRoute conformance tests

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 29, 2024
@sayboras sayboras added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/k8s-gateway-api labels Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 29, 2024
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras added the dont-merge/preview-only Only for preview or testing, don't merge it. label Feb 29, 2024
@sayboras sayboras changed the title gateway-api: Bump to the latest version for GRPCRoute tests gateway-api: Enable GRPCRoute conformance tests Mar 5, 2024
@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Mar 5, 2024
This is mainly to pick up the new GRPC Conformance tests added recently.

Relates: kubernetes-sigs/gateway-api#2745
Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to remove our manual GRPCRoute test, in favour of more
comprehensive tests added recently in upstream.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Mar 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Mar 5, 2024
@sayboras sayboras marked this pull request as ready for review March 5, 2024 13:13
@sayboras sayboras requested review from a team as code owners March 5, 2024 13:13
@sayboras sayboras added release-note/ci This PR makes changes to the CI. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Mar 5, 2024
@sayboras
Copy link
Member Author

sayboras commented Mar 5, 2024

/test

Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@sayboras sayboras enabled auto-merge March 5, 2024 13:38
@sayboras sayboras added this pull request to the merge queue Mar 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 5, 2024
Merged via the queue into main with commit f77f3c3 Mar 5, 2024
229 checks passed
@sayboras sayboras deleted the tam/test-grpc-conformance branch March 5, 2024 16:08
@jibi jibi mentioned this pull request Mar 12, 2024
16 tasks
@jibi jibi added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Mar 12, 2024
@jibi jibi added needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Needs backport from main in 1.15.2 Mar 13, 2024
@jrajahalme jrajahalme added this to Needs backport from main in 1.15.3 Mar 13, 2024
@jrajahalme jrajahalme removed this from Needs backport from main in 1.15.2 Mar 13, 2024
@jibi jibi added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 13, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 16, 2024
@jrajahalme jrajahalme moved this from Needs backport from main to Backport done to v1.15 in 1.15.3 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. feature/k8s-gateway-api ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.15.3
Backport done to v1.15
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

5 participants