Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: Update docs with network policy example #31060

Merged
merged 1 commit into from
Mar 6, 2024
Merged

ingress: Update docs with network policy example #31060

merged 1 commit into from
Mar 6, 2024

Conversation

sayboras
Copy link
Member

This is to extend the existing basic ingress docs with external lockdown CCNP, while still allows in-cluster traffic to Ingress LB IP.

Relates: #28126

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 29, 2024
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh labels Feb 29, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 29, 2024
@sayboras sayboras marked this pull request as ready for review February 29, 2024 13:15
@sayboras sayboras requested review from a team as code owners February 29, 2024 13:15
@sayboras
Copy link
Member Author

/test

@joestringer
Copy link
Member

Does it make sense to include a policy for the ingress itself too? Is that possible?

learnitall
learnitall requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I left a couple of wording and typo suggestions for you.

Documentation/network/servicemesh/http.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/http.rst Outdated Show resolved Hide resolved
examples/kubernetes/servicemesh/policy/external-lockdown.yaml Outdated Show resolved Hide resolved
Documentation/operations/troubleshooting_servicemesh.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/http.rst Outdated Show resolved Hide resolved
Documentation/network/servicemesh/http.rst Outdated Show resolved Hide resolved
@sayboras
Copy link
Member Author

sayboras commented Mar 4, 2024

Does it make sense to include a policy for the ingress itself too? Is that possible?

I have added one more policy to allow ingress traffic from a specific cidr, let me know if it's what you have in mind. Thanks.

@sayboras sayboras requested a review from learnitall March 4, 2024 03:58
@sayboras
Copy link
Member Author

sayboras commented Mar 4, 2024

/test

learnitall
learnitall requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two grammar nits, then LGTM! Thanks!

Documentation/operations/troubleshooting_servicemesh.rst Outdated Show resolved Hide resolved
examples/kubernetes/servicemesh/policy/external-lockdown.yaml Outdated Show resolved Hide resolved
@sayboras
ingress: Update docs with network policy example
cff19ff 
This is to extend the existing basic ingress docs with external lockdown
CCNP, while still allows in-cluster traffic to Ingress LB IP.

Relates: #28126
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras requested a review from learnitall March 5, 2024 03:25
@sayboras
Copy link
Member Author

sayboras commented Mar 5, 2024

/test

meyskens
meyskens approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me

@sayboras sayboras enabled auto-merge March 5, 2024 14:34
@sayboras sayboras added needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 5, 2024
@jibi jibi added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.2 Mar 12, 2024
@jibi jibi added needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.15 to Needs backport from main in 1.15.2 Mar 13, 2024
@jrajahalme jrajahalme removed this from Needs backport from main in 1.15.2 Mar 13, 2024
@jibi jibi added needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Needs backport from main in 1.14.8 Mar 13, 2024
@jrajahalme jrajahalme added this to Needs backport from main in 1.15.3 Mar 13, 2024
@jrajahalme jrajahalme removed this from Needs backport from main in 1.15.2 Mar 13, 2024
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.8 Mar 13, 2024
@jibi jibi added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 13, 2024
@thorn3r thorn3r added this to Backport pending to v1.14 in 1.14.9 Mar 13, 2024
@thorn3r thorn3r removed this from Backport pending to v1.14 in 1.14.8 Mar 13, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 16, 2024
@jrajahalme jrajahalme moved this from Needs backport from main to Backport done to v1.15 in 1.15.3 Mar 26, 2024
@jrajahalme jrajahalme mentioned this pull request Mar 26, 2024
Merged
@jrajahalme jrajahalme moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.9 Mar 26, 2024
@jrajahalme jrajahalme mentioned this pull request Mar 26, 2024
Merged
@joestringer joestringer mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

@joamaki joamaki joamaki approved these changes

@meyskens meyskens meyskens approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.9
Backport done to v1.14
1.15.3
Backport done to v1.15
cilium v1.14.9
Status: Released
cilium v1.15.3
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sayboras @joestringer @joamaki @meyskens @learnitall @jibi