New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: check license of third party Go dependencies #31129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
kind/enhancement
This would improve or streamline existing functionality.
release-note/ci
This PR makes changes to the CI.
labels
Mar 4, 2024
rolinh
force-pushed
the
pr/rolinh/license-check
branch
3 times, most recently
from
March 4, 2024 15:33
54795cf
to
5a92f10
Compare
chancez
reviewed
Mar 4, 2024
aanm
approved these changes
Mar 4, 2024
/test |
sayboras
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment on the version in go.mod, the rest seems legit, we can improve along the way.
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/license-check
branch
from
March 5, 2024 10:23
5a92f10
to
f4170bb
Compare
/test EDIT: I had to rebase already due to a go.mod conflict. |
tklauser
approved these changes
Mar 5, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/enhancement
This would improve or streamline existing functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Members of the @cilium/vendor group are currently required to inspect new or updated Go dependencies manually to verify that they comply with the CNCF policy for third party dependencies. This patch adds a tool and associated CI check to do the license verification automatically instead of relying on a manual review. When a non-conformant third party is detected, the CI check fails with a message indicating which dependency is a problem and links to relevant resources. Example:
See example failed CI run.