Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] envoy: Bump golang version to 1.21.8 #31223

Merged
merged 1 commit into from Mar 8, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Mar 7, 2024

This is to pick up the new image with updated golang version, and other dependency bump.

Related commit: cilium/proxy@bbde409
Related build: https://github.com/cilium/proxy/actions/runs/8179371187/job/22365308893

This is to pick up the new image with updated golang version, and other
dependency bump.

Related commit: cilium/proxy@bbde409
Related build: https://github.com/cilium/proxy/actions/runs/8179371187/job/22365308893

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Mar 7, 2024
@sayboras sayboras added the release-blocker/1.13 This issue will prevent the release of the next version of Cilium. label Mar 7, 2024
@sayboras
Copy link
Member Author

sayboras commented Mar 7, 2024

/test-backport-1.13

Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig Etcd Check connectivity

Failure Output

FAIL: Pods are not ready in time: timed out waiting for pods with filter  to be ready: 4m0s timeout expired

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.19/464/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #30802 (92.21% similarity)

Job 'Cilium-PR-K8s-1.21-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from testclient-ssxsr pod to service http://192.168.56.11:30921 failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/418/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #30802 (90.94% similarity)

@sayboras sayboras marked this pull request as ready for review March 7, 2024 13:42
@sayboras sayboras requested a review from a team as a code owner March 7, 2024 13:42
@sayboras
Copy link
Member Author

sayboras commented Mar 7, 2024

/test-1.25-4.19

@jrajahalme
Copy link
Member

/test-1.21-4.19

@jrajahalme
Copy link
Member

/test-1.22-4.19

@jrajahalme
Copy link
Member

/test-1.21-4.19

@sayboras
Copy link
Member Author

sayboras commented Mar 7, 2024

Test summary:

Required reviews are in, so marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 7, 2024
@joestringer
Copy link
Member

/test-1.21-4.19

@joestringer
Copy link
Member

Hmm, @sayboras do you think that test is just broken on v1.13? I wonder if that regressed at some point (doesn't seem likely related to this PR, but could potentially affect all v1.13 backports 🤔 )

@sayboras
Copy link
Member Author

sayboras commented Mar 8, 2024

do you think that test is just broken on v1.13? I wonder if that regressed at some point (doesn't seem likely related to this PR, but could potentially affect all v1.13 backports 🤔 )

Ah I think it's not consistently broken, but more about a flake. As the previous run was failed for another test case.

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/418/

@joestringer joestringer merged commit 317016f into v1.13 Mar 8, 2024
150 of 151 checks passed
@joestringer joestringer deleted the tam/proxy-golang-1.13 branch March 8, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.13 This issue will prevent the release of the next version of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants