Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove deprecated values for KPR #31286

Merged
merged 1 commit into from Mar 27, 2024
Merged

cleanup: Remove deprecated values for KPR #31286

merged 1 commit into from Mar 27, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Mar 11, 2024 •
edited

Description

This commit is to remove all deprecated values (strict, disabled, probe
and partial) for kubeProxyReplacement.

Relates: #26036, #26496

Testing

Testing was done with the latest cilium-cli with commit hash while waiting for the next release.

Relates: #31286

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 11, 2024
@sayboras sayboras force-pushed the tam/remove-kpr-deprecated-values branch 2 times, most recently from 5ee6dde to 5b76701 Compare March 11, 2024 04:56
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Mar 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 11, 2024
@sayboras sayboras added kind/cleanup This includes no functional changes. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 11, 2024
@sayboras sayboras force-pushed the tam/remove-kpr-deprecated-values branch from 5b76701 to 0fc86ab Compare March 11, 2024 05:13
@sayboras
Copy link
Member Author

/test

@sayboras sayboras mentioned this pull request Mar 11, 2024
Closed
@sayboras sayboras force-pushed the tam/remove-kpr-deprecated-values branch 2 times, most recently from 7287083 to 2af80fa Compare March 11, 2024 10:28
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review March 11, 2024 12:00
@sayboras sayboras requested review from a team as code owners March 11, 2024 12:00
danehans
danehans approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the understanding that @qmonnet @tklauser review comments will be resolved before merging.

Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
daemon/cmd/kube_proxy_replacement_test.go Show resolved Hide resolved
@sayboras sayboras force-pushed the tam/remove-kpr-deprecated-values branch from 914494c to 52c5e43 Compare March 24, 2024 12:20
@sayboras sayboras requested a review from qmonnet March 24, 2024 12:20
@sayboras
Copy link
Member Author

/test

@sayboras sayboras removed the request for review from meyskens March 24, 2024 13:29
qmonnet
qmonnet approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tam!

@qmonnet qmonnet added the upgrade-impact This PR has potential upgrade or downgrade impact. label Mar 25, 2024
aanm
aanm approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried about the set-strings at first. I'm glad it got fixed in the meanwhile

Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 25, 2024
@sayboras sayboras removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 25, 2024
@sayboras sayboras force-pushed the tam/remove-kpr-deprecated-values branch from 52c5e43 to f3b9be4 Compare March 25, 2024 22:52
@sayboras
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 25, 2024
@sayboras
cleanup: Remove deprecated values for KPR
e17e123 
This commit is to remove all deprecated values (strict, disabled, probe
and partial) for kubeProxyReplacement.

Relates: #26036, #26496

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/remove-kpr-deprecated-values branch from f3b9be4 to e17e123 Compare March 26, 2024 08:52
@sayboras
Copy link
Member Author

The last force push is only doc change, I don't think full ci is required.

https://github.com/cilium/cilium/compare/f3b9be46f458a2c42794d3d12bfef2a9f829b5a9..e17e1239a2e160bf166d824867f3c22f4672b35c

@sayboras
Copy link
Member Author

/test

@sayboras sayboras requested a review from youngnick March 26, 2024 13:36
@squeed squeed removed the request for review from youngnick March 26, 2024 14:36
@sayboras sayboras requested review from youngnick and removed request for youngnick March 26, 2024 22:34
@tklauser tklauser added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit 6a83269 Mar 27, 2024
226 checks passed
@tklauser tklauser deleted the tam/remove-kpr-deprecated-values branch March 27, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@brb brb brb approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@tklauser tklauser tklauser approved these changes

@squeed squeed squeed approved these changes

@gentoo-root gentoo-root gentoo-root approved these changes

@danehans danehans danehans approved these changes

@aanm aanm aanm approved these changes

@youngnick youngnick youngnick approved these changes

@qmonnet qmonnet qmonnet approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. upgrade-impact This PR has potential upgrade or downgrade impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet