Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose verifier logs in socketlb #31321

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Verbose verifier logs in socketlb #31321

merged 1 commit into from
Apr 4, 2024

Conversation

gentoo-root
Copy link
Contributor 

Print verbose verifier logs on verifier errors in socketlb

@maintainer-s-little-helper
Copy link

Commit d0730f1 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 11, 2024
@gentoo-root
socketlb: Print verbose verifier logs
de695fb 
Use %+v when printing verifier errors to print the full log instead of
just the last line, similar to pkg/datapath/loader/netlink.go.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 11, 2024
@gentoo-root gentoo-root added the release-note/misc This PR makes changes that have no direct user impact. label Mar 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 11, 2024
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root gentoo-root marked this pull request as ready for review March 28, 2024 12:28
@gentoo-root gentoo-root requested a review from a team as a code owner March 28, 2024 12:28
@gentoo-root gentoo-root requested a review from lmb March 28, 2024 12:28
lmb
lmb approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck! ;)

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 2, 2024
@julianwiedmann julianwiedmann added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Apr 4, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Apr 4, 2024
Merged via the queue into cilium:main with commit 5dc6baa Apr 4, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gentoo-root @lmb @julianwiedmann