Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: Add the documentation for using serviceAdvertisements #31331

Merged
merged 1 commit into from Mar 18, 2024
Merged

bgpv1: Add the documentation for using serviceAdvertisements #31331

merged 1 commit into from Mar 18, 2024

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Mar 12, 2024 •
edited

Related to #31245
Related to #30963

Add the documentation for using `serviceAdvertisements`

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 12, 2024
@chaunceyjiang chaunceyjiang force-pushed the bgp_docs branch 2 times, most recently from 8c2026b to b6ecee0 Compare March 12, 2024 02:59
YutaroHayakawa
YutaroHayakawa requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Few comments.

Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
Documentation/network/bgp-control-plane.rst Outdated Show resolved Hide resolved
@chaunceyjiang
bgpv1: Add the documentation for using serviceAdvertisements
132b762 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang marked this pull request as ready for review March 15, 2024 07:44
@chaunceyjiang chaunceyjiang requested review from a team as code owners March 15, 2024 07:44
qmonnet
qmonnet approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/bgp release-note/misc This PR makes changes that have no direct user impact. labels Mar 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2024
@qmonnet
Copy link
Member

qmonnet commented Mar 15, 2024

/test

harsimran-pabla
harsimran-pabla approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@harsimran-pabla harsimran-pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs 🙏

YutaroHayakawa
YutaroHayakawa approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 18, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 18, 2024
Merged via the queue into cilium:main with commit 5067744 Mar 18, 2024
59 checks passed
@chaunceyjiang chaunceyjiang deleted the bgp_docs branch March 18, 2024 10:50
@chaunceyjiang chaunceyjiang mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@qmonnet qmonnet qmonnet approved these changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

Assignees
No one assigned
Labels
area/bgp area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chaunceyjiang @qmonnet @YutaroHayakawa @harsimran-pabla @julianwiedmann