Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.14] bgpv1: Disable PodCIDR Reconciler for unsupported IPAM modes #31353

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[v1.14] bgpv1: Disable PodCIDR Reconciler for unsupported IPAM modes #31353

merged 1 commit into from
Mar 15, 2024

Conversation

YutaroHayakawa
Copy link
Member

Manual backport of #31181.

bgpv1: Disable PodCIDR Reconciler for unsupported IPAM modes

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Mar 12, 2024
@YutaroHayakawa YutaroHayakawa requested review from a team, danehans and harsimran-pabla and removed request for a team and danehans March 12, 2024 14:44
@YutaroHayakawa
bgpv1: Disable PodCIDR Reconciler for unsupported IPAM modes
a3bb2a5 
[ upstream commit 2764994 ]

[ backporter's note: Discarded document changes. We'll backport it
  together with other recent document changes.
  Reconcilers are not yet separated into the different directly in v1.14.
  types/utils.go didn't exist. Added. ]

PodCIDR shouldn't take any effect for the unsupported IPAM modes. Modify
ExportPodCIDRReconciler's constructor to not provide ConfigReconciler
for unsupported IPAMs.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa force-pushed the disable-podcidr-advertisement-for-unsupported-ipam-1.14 branch from ec33932 to a3bb2a5 Compare March 12, 2024 14:54
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review March 12, 2024 15:20
@YutaroHayakawa YutaroHayakawa requested a review from a team as a code owner March 12, 2024 15:20
@YutaroHayakawa
Copy link
Member Author

/test-backport-1.14

@YutaroHayakawa
Copy link
Member Author

Cilium IPSec upgrade: #29846
Conformance AKS: #26102

@YutaroHayakawa
Copy link
Member Author

Conformance AKS: #29845

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 14, 2024
@YutaroHayakawa YutaroHayakawa merged commit 07d49dd into cilium:v1.14 Mar 15, 2024
59 checks passed
@jrajahalme jrajahalme mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

Assignees
No one assigned
Labels
area/bgp backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
No open projects
cilium v1.14.9
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YutaroHayakawa @dylandreimerink @harsimran-pabla