Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: Fix missing labels from SelectorCache selectors #31358

Merged

Conversation

christarazi
Copy link
Member

During the refactor of the below commit, it seems the labels were left
out inadvertently, breaking the cilium policy selectors command that
displays the labels/name of the policy from which the selectors
originate from.

Fixes: 501944c ("policy/selectorcache: invert identitySelector interface")

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi christarazi requested a review from a team as a code owner March 12, 2024 23:29
@christarazi christarazi added kind/bug This is a bug in the Cilium logic. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. labels Mar 12, 2024
@christarazi christarazi requested a review from squeed March 12, 2024 23:29
@christarazi
Copy link
Member Author

cc @squeed

@christarazi christarazi added needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Mar 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.8 Mar 12, 2024
@jrajahalme jrajahalme removed this from Needs backport from main in 1.15.2 Mar 13, 2024
@thorn3r thorn3r added this to Needs backport from main in 1.14.9 Mar 13, 2024
@thorn3r thorn3r removed this from Needs backport from main in 1.14.8 Mar 13, 2024
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks.

During the refactor of the below commit, it seems the labels were left
out inadvertently, breaking the `cilium policy selectors` command that
displays the labels/name of the policy from which the selectors
originate from.

Fixes: 501944c ("policy/selectorcache: invert identitySelector interface")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/fix-cmd-selectors-output branch from 6c475e7 to 77d7ac1 Compare March 14, 2024 20:42
@christarazi
Copy link
Member Author

christarazi commented Mar 14, 2024

@christarazi christarazi added this pull request to the merge queue Mar 14, 2024
Merged via the queue into cilium:main with commit 65bbf3f Mar 14, 2024
58 of 62 checks passed
@christarazi christarazi deleted the pr/christarazi/fix-cmd-selectors-output branch March 14, 2024 23:48
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2024
@gandro gandro mentioned this pull request Mar 19, 2024
21 tasks
@gandro gandro added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 19, 2024
@gandro
Copy link
Member

gandro commented Mar 19, 2024

The code looks sufficiently different on v1.14 that I don't feel comfortable backporting this myself. Marking as "backport/author".

@gandro gandro added the backport/author The backport will be carried out by the author of the PR. label Mar 19, 2024
@squeed squeed removed backport/author The backport will be carried out by the author of the PR. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Mar 19, 2024
@squeed
Copy link
Contributor

squeed commented Mar 19, 2024

This doesn't need backport to v1.14 :-).

@gandro gandro mentioned this pull request Mar 19, 2024
10 tasks
@christarazi
Copy link
Member Author

christarazi commented Mar 19, 2024

Ah, yes you're right. I saw a mention of fixed commit in the commit msg being in a v1.14 backport PR, but it was not part of the backport list and did not check my assumption, good catch thanks.

@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 21, 2024
@jrajahalme jrajahalme added this to Needs backport from main in 1.14.10 Mar 26, 2024
@jrajahalme jrajahalme removed this from Needs backport from main in 1.14.9 Mar 26, 2024
@asauber asauber added this to Needs backport from main in 1.14.11 Apr 11, 2024
@asauber asauber removed this from Needs backport from main in 1.14.10 Apr 11, 2024
@nebril nebril added this to Needs backport from main in 1.14.12 May 10, 2024
@nebril nebril removed this from Needs backport from main in 1.14.11 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
1.14.12
Needs backport from main
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

3 participants