-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
policy: Fix missing labels from SelectorCache selectors #31358
policy: Fix missing labels from SelectorCache selectors #31358
Conversation
cc @squeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, thanks.
During the refactor of the below commit, it seems the labels were left out inadvertently, breaking the `cilium policy selectors` command that displays the labels/name of the policy from which the selectors originate from. Fixes: 501944c ("policy/selectorcache: invert identitySelector interface") Signed-off-by: Chris Tarazi <chris@isovalent.com>
6c475e7
to
77d7ac1
Compare
The code looks sufficiently different on v1.14 that I don't feel comfortable backporting this myself. Marking as "backport/author". |
This doesn't need backport to v1.14 :-). |
Ah, yes you're right. I saw a mention of fixed commit in the commit msg being in a v1.14 backport PR, but it was not part of the backport list and did not check my assumption, good catch thanks. |
During the refactor of the below commit, it seems the labels were left
out inadvertently, breaking the
cilium policy selectors
command thatdisplays the labels/name of the policy from which the selectors
originate from.
Fixes: 501944c ("policy/selectorcache: invert identitySelector interface")
Signed-off-by: Chris Tarazi chris@isovalent.com