Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: lb: have __lb*_rev_nat() take the source port from CT tuple #31364

Merged
merged 1 commit into from Mar 25, 2024
Merged

bpf: lb: have __lb*_rev_nat() take the source port from CT tuple #31364

merged 1 commit into from Mar 25, 2024

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Mar 13, 2024 •
edited

Instead of loading the source port from the packet, obtain it from the provided CT tuple.

Support IPv4 fragmentation for service backends.

@julianwiedmann
bpf: lb: have __lb*_rev_nat() take the source port from CT tuple
bf58a4a 
Instead of loading the source port from the packet, obtain it from the
provided CT tuple.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels Mar 13, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added the dont-merge/preview-only Only for preview or testing, don't merge it. label Mar 13, 2024
@julianwiedmann
Copy link
Member Author

I want to have a quick look whether all callers really provide a fully populated tuple. And if there's any complexity surprises. But should be good for review.

@julianwiedmann julianwiedmann marked this pull request as ready for review March 13, 2024 10:30
@julianwiedmann julianwiedmann requested a review from a team as a code owner March 13, 2024 10:30
@julianwiedmann
Copy link
Member Author

I want to have a quick look whether all callers really provide a fully populated tuple. And if there's any complexity surprises. But should be good for review.

all good.

@julianwiedmann julianwiedmann added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed dont-merge/preview-only Only for preview or testing, don't merge it. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Mar 16, 2024
gentoo-root
gentoo-root approved these changes Mar 25, 2024
View reviewed changes
bpf/lib/lb.h Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 25, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 25, 2024
@julianwiedmann julianwiedmann added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Mar 25, 2024
Merged via the queue into cilium:main with commit 460fc38 Mar 25, 2024
63 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-bpf-lb-rev-nat branch March 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

Assignees
No one assigned
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @gentoo-root