Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: add message if error is ENOTSUP #31413

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Mar 15, 2024

I was trying to install cilium in a machine without a vxlan module available. Add a helpful message for the next time this happens.

Tested by running:

PRIVILEGED_TESTS=1 go test -test.v -test.run TestSetupTunnelDevice

on said machine, and got the following output:
...

        Error:          Received unexpected error: setting up vxlan device: creating vxlan device: creating device cilium_vxlan: operation not supported, maybe module for vxlan is not loaded?
	Test:           TestSetupTunnelDevice/Vxlan

@kkourt kkourt requested a review from a team as a code owner March 15, 2024 10:11
@kkourt kkourt requested a review from rgo3 March 15, 2024 10:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2024
I was trying to install cilium in a machine without a vxlan module
available. Add a helpful message for the next time this happens.

Tested by running:
> PRIVILEGED_TESTS=1 go test  -test.v -test.run TestSetupTunnelDevice

on said machine, and got the following output:
...

```
        Error:          Received unexpected error: setting up vxlan device: creating vxlan device: creating device cilium_vxlan: operation not supported, maybe kernel module for vxlan is not available?
	Test:           TestSetupTunnelDevice/Vxlan
```

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Mar 15, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2024
@julianwiedmann julianwiedmann added the sig/loader Impacts the loading of BPF programs into the kernel. label Mar 15, 2024
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! I believe we should even backport this - it's easy enough, and helps users.

@julianwiedmann
Copy link
Member

/test

@julianwiedmann julianwiedmann added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Mar 15, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 6436447 Mar 15, 2024
225 checks passed
@julianwiedmann julianwiedmann deleted the pr/kkourt/netlink-message branch March 15, 2024 14:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2024
@gandro gandro mentioned this pull request Mar 19, 2024
21 tasks
@gandro gandro added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 19, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

4 participants