-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images: Update LLVM to 17.0.6 #31418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8298b1e
to
4fa4784
Compare
74e1ee0
to
5ef0950
Compare
/test |
e86382f
to
2006b4e
Compare
/test |
borkmann
approved these changes
Mar 20, 2024
2006b4e
to
1b91791
Compare
c317c88
to
82f7fd7
Compare
/test |
/test |
dd0e4e2
to
3a8b1bb
Compare
/test |
YutaroHayakawa
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a question.
brlbil
approved these changes
Apr 12, 2024
Instead of a custom script prepare.sh, use install-llvm-action in integration-test.yaml for consistency with lint-build-commits.yaml. Although install-llvm-action doesn't check the signature, newer versions of LLVM binaries are not signed anyway, so this code would need to be removed with the upgrade to LLVM 17. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
After the upgrade to LLVM 17, it's possible to uncomment __attribute__((btf_decl_tag(description))). Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
After upgrade to Clang 17, the workaround to pass the verifier with Clang 10 became irrelevant. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
3a8b1bb
to
66f1f91
Compare
/test |
tklauser
approved these changes
Apr 16, 2024
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1]. Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2]. [^1]: https://apt.llvm.org/ [^2]: cilium/cilium#31418
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1]. Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2]. [^1]: https://apt.llvm.org/ [^2]: cilium/cilium#31418 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1]. Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2]. [^1]: https://apt.llvm.org/ [^2]: cilium/cilium#31418 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1]. Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2]. [^1]: https://apt.llvm.org/ [^2]: cilium/cilium#31418 Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
to cilium/proxy
that referenced
this pull request
Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1]. Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2]. [^1]: https://apt.llvm.org/ [^2]: cilium/cilium#31418 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's finally happening!
Preceding BPF fixes: #31403, #31459, #31849