Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Update LLVM to 17.0.6 #31418

Merged
merged 5 commits into from
Apr 16, 2024
Merged

images: Update LLVM to 17.0.6 #31418

merged 5 commits into from
Apr 16, 2024

Conversation

gentoo-root
Copy link
Contributor

@gentoo-root gentoo-root commented Mar 15, 2024

It's finally happening!

Preceding BPF fixes: #31403, #31459, #31849

images: Update LLVM to 17.0.6

@gentoo-root gentoo-root added the release-note/misc This PR makes changes that have no direct user impact. label Mar 15, 2024
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 11, 2024
@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root
Copy link
Contributor Author

/test

@gentoo-root gentoo-root marked this pull request as ready for review April 11, 2024 22:51
@gentoo-root gentoo-root requested review from a team as code owners April 11, 2024 22:51
@gentoo-root gentoo-root requested review from a team as code owners April 11, 2024 22:51
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 11, 2024
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question.

gentoo-root and others added 5 commits April 12, 2024 23:30
Instead of a custom script prepare.sh, use install-llvm-action in
integration-test.yaml for consistency with lint-build-commits.yaml.
Although install-llvm-action doesn't check the signature, newer versions
of LLVM binaries are not signed anyway, so this code would need to be
removed with the upgrade to LLVM 17.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
After the upgrade to LLVM 17, it's possible to uncomment
__attribute__((btf_decl_tag(description))).

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
After upgrade to Clang 17, the workaround to pass the verifier with
Clang 10 became irrelevant.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root
Copy link
Contributor Author

/test

@tklauser tklauser enabled auto-merge April 16, 2024 07:43
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 16, 2024
@tklauser tklauser added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit e4316b9 Apr 16, 2024
497 checks passed
@tklauser tklauser deleted the pr/max/upgrade-llvm-17-3 branch April 16, 2024 07:51
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1].
Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2].

[^1]: https://apt.llvm.org/
[^2]: cilium/cilium#31418
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1].
Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2].

[^1]: https://apt.llvm.org/
[^2]: cilium/cilium#31418

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1].
Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2].

[^1]: https://apt.llvm.org/
[^2]: cilium/cilium#31418

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1].
Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2].

[^1]: https://apt.llvm.org/
[^2]: cilium/cilium#31418

Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit to cilium/proxy that referenced this pull request Apr 17, 2024
Upstream distribution no longer lists clang 15 for ubuntu 22.04 [^1].
Additionally, cilium/cilium repo also moves to clang/llvm 17 [^2].

[^1]: https://apt.llvm.org/
[^2]: cilium/cilium#31418

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants