[v1.14] gh/workflows: IPsec key rotation improvements #31429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.14
|
/test-backport-1.14 |
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
de3a0f6
to
94b6f78
Compare
|
/test-backport-1.14 |
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
94b6f78
to
fbf3a34
Compare
|
/test-backport-1.14 |
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
fbf3a34
to
1665948
Compare
|
/test-backport-1.14 |
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
1665948
to
2c7221a
Compare
|
/test-backport-1.14 |
|
I believe there's some conflicting work in the pipeline, so let's see how we get this in the easiest. |
julianwiedmann
added
the
dont-merge/preview-only
viktor-kurchenko
approved these changes
Mar 18, 2024
jrajahalme
approved these changes
Mar 19, 2024
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
2c7221a
to
614db9d
Compare
|
/test-backport-1.14 |
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
614db9d
to
39eb11d
Compare
|
/test-backport-1.14 |
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
39eb11d
to
7530971
Compare
|
/test-backport-1.14 |
julianwiedmann
removed
the
dont-merge/preview-only
julianwiedmann
added
area/encryption
|
@julianwiedmann Is there something in particular I should review? This is just a backport for two PRs I already reviewed, no? |
Right, sorry - I should have noted that. The interesting part is the adjustments for the new key system in 5e1e120. This should be very much in line with the changes in #31428. |
pchaigno
approved these changes
Apr 8, 2024
maintainer-s-little-helper
bot
added
ready-to-merge
julianwiedmann
added
the
dont-merge/needs-rebase
[ upstream commit 5c988ee ] Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit 687a4f5 ] [ backporter's notes: also apply diff from e448644 and e8ddc88 to support new key system ] The action is for testing whether IPsec key rotations do not cause any packet drops. NB for backporters: this commit just moves the code for the workflow into the new action, and the timeout increase. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit 5c06c8e ] First, this commit includes the IPsec key rotation tests action. Second, it changes the CLI exec name and path to "./cilium-cli", so that it can be used by the key rotation action and friends. Third, it runs the IPsec tests only if the matrix.ipsec is set to "true". A subsequent commit will extend the matrix configuration accordingly. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit f99ddb9 ] The file name is non-ideal, but changing it would require changing many files :-( For each PR we will run 1.25 w/o IPsec and 1.28 w/ IPsec. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
pr/jwi/v1.14/ipsec-rotation
branch
from
7530971
to
f4b64a5
Compare
|
Innocent rebase to pick up #31627. |
|
/test-backport-1.14 |
julianwiedmann
removed
the
dont-merge/needs-rebase
lmb
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of
Once this PR is merged, a GitHub action will update the labels of these PRs: