Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.15 - Author backport] envoy: enable k8s secret watch even if only CEC is enabled #31451

Merged

Commits on Mar 18, 2024

  1. envoy: enable k8s secret watch even if only CEC is enabled

    Currently, the K8s Secret watch (used by Envoy SecretSync (K8s TLS Secret -> Envoy SDS))
    is only active if either Ingress Controller or Gateway API is enabled.
    
    Hence Secrets aren't available via SDS in cases where only CiliumEnvoyConfig is
    enabled (`--enable-envoy-config`).
    
    This commit fixes this by enabling the K8s Secret watch also in cases where only
    CiliumEnvoyConfig is enabled (without Ingress Controller and/or Gateway API
    being enabled).
    
    Fixes: cilium#26005
    
    Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
    mhofstetter committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    adcce49 View commit details
    Browse the repository at this point in the history