Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ipsec: document native-routing + Egress proxy case #31478

Merged
merged 1 commit into from Mar 26, 2024
Merged

docs: ipsec: document native-routing + Egress proxy case #31478

merged 1 commit into from Mar 26, 2024

Conversation

julianwiedmann
Copy link
Member

Let the docs reflect the limitation from
GHSA-j89h-qrvr-xc36.

@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch feature/ipsec Relates to Cilium's IPsec feature needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 19, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review March 19, 2024 09:37
@julianwiedmann julianwiedmann requested review from a team as code owners March 19, 2024 09:37
learnitall
learnitall reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to the advisory?

@pchaigno pchaigno requested review from jschwinger233 and removed request for pchaigno March 20, 2024 21:57
@julianwiedmann
docs: ipsec: document native-routing + Egress proxy case
ba54f12 
Let the docs reflect the limitation from
GHSA-j89h-qrvr-xc36.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

learnitall
learnitall approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 25, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 26, 2024
Merged via the queue into cilium:main with commit a2bf108 Mar 26, 2024
59 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-ipsec-docs branch March 26, 2024 06:41
@joamaki joamaki mentioned this pull request Apr 2, 2024
Merged
8 tasks
@joamaki joamaki added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
Merged
10 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
Merged
13 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 2, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 4, 2024
This was referenced Apr 11, 2024
Open
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferozsalam ferozsalam ferozsalam approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@julianwiedmann @ferozsalam @jschwinger233 @jrajahalme @learnitall @joamaki