Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: fix coredns logs retrieval in conformance-clustermesh #31509

Merged
merged 1 commit into from Mar 21, 2024

Conversation

giorio94
Copy link
Member

The amount of log lines to display is limited to 10 by default when using a label selector. Let's switch to unlimited.

--tail=-1:
Lines of recent log file to display. Defaults to -1 with no selector,
showing all log lines otherwise 10, if a selector is provided.

Fixes: b1774e1 ("gha: retrieve additional coredns-related troubleshooting info")

The amount of log lines to display is limited to 10 by default when
using a label selector. Let's switch to unlimited.

  --tail=-1:
    Lines of recent log file to display. Defaults to -1 with no selector,
    showing all log lines otherwise 10, if a selector is provided.

Fixes: b1774e1 ("gha: retrieve additional coredns-related troubleshooting info")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Mar 19, 2024
@giorio94 giorio94 requested review from a team as code owners March 19, 2024 17:24
@giorio94
Copy link
Member Author

/test

Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlimited unlocked, thanks)

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2024
@aditighag aditighag added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 392a50b Mar 21, 2024
75 checks passed
@aditighag aditighag deleted the pr/giorio94/main/gha-troubleshooting branch March 21, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants