gha: configure fully-qualified DNS names as external targets #31510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
|
/test |
1 similar comment
|
/test |
giorio94
force-pushed
the
pr/giorio94/main/gha-fully-qualified-dns
branch
2 times, most recently
from
7c0f2a7
to
2f58a66
Compare
|
/test |
giorio94
force-pushed
the
pr/giorio94/main/gha-fully-qualified-dns
branch
from
2f58a66
to
f88f046
Compare
|
/test |
giorio94
force-pushed
the
pr/giorio94/main/gha-fully-qualified-dns
branch
from
f88f046
to
53c263d
Compare
|
/test |
This prevents possible shenanigans caused by search domains possibly configured on the runner, and propagated to the pods. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/gha-fully-qualified-dns
branch
from
53c263d
to
0e5a0ef
Compare
|
/test |
viktor-kurchenko
approved these changes
Apr 5, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
needs-backport/1.14
9 tasks
jschwinger233
added
backport-pending/1.15
5 tasks
jschwinger233
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
This was referenced Apr 29, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents possible shenanigans caused by search domains possibly configured on the runner, and propagated to the pods.
Related: cilium/cilium-cli#2433