[v1.14] test: Remove duplicate Cilium deployments in some datapath config tests #31521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disabling IPv6 BPF masquerading in datapath configuration tests using the host firewall, we accidentally duplicated the command to deploy Cilium for some of the tests. Let's clean this up to avoid slowing down the tests. Fixes: 934e1f2 ("daemon: Forbid IPv6 BPF masquerading with the host firewall") Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
added
kind/bug/CI
maintainer-s-little-helper
bot
added
the
backport/1.14
|
/test-backport-1.14 |
julianwiedmann
removed
the
backport/1.15
julianwiedmann
changed the title
|
Not sure how to trigger the |
|
Think we can merge - this only touches test code, and the relevant tests are green. |
julianwiedmann
added
the
ready-to-merge
jrajahalme
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling IPv6 BPF masquerading in datapath configuration tests using the host firewall, we accidentally duplicated the command to deploy Cilium for some of the tests. Let's clean this up to avoid slowing down the tests.
Fixes: 934e1f2 ("daemon: Forbid IPv6 BPF masquerading with the host firewall")
Partial backport from #31511.