loader: clean up tcx bpf_links created by newer Cilium versions #31553
+206
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ti-mo
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
rgo3
approved these changes
Mar 22, 2024
|
Do we need a 1.13 backport? TCX will be released with 1.16, so only 1.15 and 1.14 need the downgrade path or did we change that policy? |
ti-mo
removed
the
needs-backport/1.13
No, 1.13 is not needed. Technically only 1.15 needs it. |
borkmann
approved these changes
Mar 22, 2024
The arguments to the replaceDatapath functions are already quite numerous and make the function signature hard to read. In preparation for future commits, this patch aggregates almost all arguments to the function into one option parameter. Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
ti-mo
force-pushed
the
tb/remove-tcx-links
branch
from
0d6b950
to
e869773
Compare
|
/test |
A follow-up commit will introduce attaching TC programs using tcx. Those attachments cannot be overridden using netlink. If an older version of Cilium wants to replace an TC program on a managed interface, it'll need to remove the tcx attachment first. This commit teaches the agent to remove leftover tcx link objects from previous installs, before reattaching it using netlink. Note that this transition is never seamless, since some time passes between deleting the link and attaching the new program using netlink. However, as explained in 7a8e3c8 ("loader: clean up XDP bpf_links created by newer Cilium versions"), this downgrade path should rarely happen. Signed-off-by: Robin Gögge <r.goegge@isovalent.com> Co-authored-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/remove-tcx-links
branch
from
e869773
to
082e607
Compare
|
Had to make the |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
4 tasks
ti-mo
added
backport-pending/1.15
rgo3
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the backportable part of #30103 and needs to be merged and backported independently in order for the downgrade path (and tests) to work.