bpf: nodeport: split off LB logic in nodeport_lb*() #31590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use positive logic in the "use identity forward?" condition. Also limit the additional sanity-checks for the forwarded identity to this code path. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
nodeport_lb*() has grown into a massive function, and its current code
flow is rather confusing:
if (is-svc-request) {
/* do svc stuff */
} else {
/* do other stuff and return */
}
/* do more svc stuff */
Clean this up by pulling all the SVC logic into a separate function.
Long-term this will make it easier to configure BPF masquerading
independently from ENABLE_NODEPORT.
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
julianwiedmann
added
sig/datapath
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
julianwiedmann
changed the title
|
No clue why the diff for |
jibi
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
- all the svc logic moved into
nodeport_svc_lb{4,6} - some extra churn due to some values becoming pointers
- the else branch for the is-not-svc-request case always returned or tailcall'd into another func so should be fine to move all the svc logic inside the is-svc-request branch
LGTM
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating this particular function is confusing, and to support #13732 we'll eventually need to cleanly split the LB / NAT paths anyway. So let's bite the bullet and go ahead with it.