BGPv2: Updates CiliumBGPNodeConfigOverride Type #31598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
harsimran-pabla
approved these changes
Mar 26, 2024
rastislavs
approved these changes
Mar 26, 2024
|
/ci-ginkgo |
|
c72e9f4 added this field to CiliumNode after this PR was pushed. I'm going to rebase to see if the commit resolves this CI flake. |
Previously, the CiliumBGPNodeConfigOverrideSpec included the `nodeRef` field for referencing the name of the node for which the BGP configuration is overridden. This approach introduces the potential for conflicts by multiple CiliumBGPNodeConfigOverride resources referencing the same CiliumBGPNodeConfig. This PR removes the `nodeRef` field and updates the CiliumBGPNodeConfigOverride spec so users understand that the name of the CiliumBGPNodeConfig and CiliumBGPNodeConfigOverride must match for the configuration overrides to be applied. Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
danehans
force-pushed
the
bgpv2_node_cfg_override
branch
from
a7f4feb
to
364fb04
Compare
|
/test |
1 similar comment
|
/test |
harsimran-pabla
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
harsimran-pabla
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/ci-clustermesh |
danehans
changed the title
danehans
changed the title
danehans
changed the title
|
@YutaroHayakawa since #31684 requires this PR, it would be great to get this merged. cc: @joestringer |
|
It still needs the review from sig-k8s. Let me ping @tommyp1ckles. |
|
@YutaroHayakawa do you have any suggestions for someone else to review this PR? |
|
Ok, Tom is not available now. Let me randomly select a person from sig-k8s and request a review from @squeed 🙏 |
tommyp1ckles
approved these changes
Apr 9, 2024
|
This needs a proper release note, unless we are removing a field that was never released, as well as an entry in the UPGRADING notes. Usually we first mark a field as deprecated for one release, then remove the field. As this is v2alpha1 that may be loosened, but only for good reason. |
|
@squeed yes, this is a change to an unreleased API type. |
|
Easy. Approved, thanks. |
squeed
approved these changes
Apr 15, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CiliumBGPNodeConfigOverrideSpec included the
nodeReffield for referencing the name of a CiliumBGPNodeConfig to override. This approach introduces the potential for conflicts by multiple CiliumBGPNodeConfigOverride resources referencing the same CiliumBGPNodeConfig.This PR removes the
nodeReffield and updates the CiliumBGPNodeConfigOverride spec so users understand that the name of the CiliumBGPNodeConfig and CiliumBGPNodeConfigOverride must match for the configuration overrides to be applied.