test/verifier: Sort BPF program names for stable output #31617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-root
force-pushed
the
sort-bpf-names
branch
from
b616f0d
to
1104233
Compare
|
/test |
rgo3
approved these changes
Mar 27, 2024
Repeated runs of `go test ./test/verifier` print program complexity in random order. Sorting by external wrappers is not feasibly, because there are groups (each object file compiled with a certain set of defines) that need to be sorted individually. Make the output stable. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
gentoo-root
force-pushed
the
sort-bpf-names
branch
from
1104233
to
e17b8a6
Compare
|
/test |
brlbil
approved these changes
Mar 27, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeated runs of
go test ./test/verifierprint program complexity in random order. Sorting by external wrappers is not feasibly, because there are groups (each object file compiled with a certain set of defines) that need to be sorted individually. Make the output stable.