Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: update nodeinit image using renovate #31641

Merged
merged 2 commits into from Mar 28, 2024
Merged

helm: update nodeinit image using renovate #31641

merged 2 commits into from Mar 28, 2024

Conversation

tklauser
Copy link
Member

Use image digest for the nodeinit image in the helm charts and let renovatebot keep the image up to date.

See commits for details.

@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels Mar 27, 2024
@tklauser tklauser requested review from a team as code owners March 27, 2024 13:46
@tklauser
Copy link
Member Author

/test

@tklauser tklauser added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 27, 2024
@tklauser
install/kubernetes: use digest for nodeinit image
ed64c6c 
Like other images used in the Cilium helm chart, use a digest in
addition to the tag for the nodeinit image.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
install/kubernetes: use renovate to update quay.io/cilium/startup-script
ffb400f 
Make sure the latest version of the image is used in the helm charts by
letting renovatebot update it automatically.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/renovate-nodeinit branch from e6309ec to ffb400f Compare March 27, 2024 14:01
@tklauser
Copy link
Member Author

/test

gandro
gandro approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm lgtm!

@tklauser tklauser enabled auto-merge March 27, 2024 15:54
@tklauser tklauser added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit ac804b6 Mar 28, 2024
226 checks passed
@tklauser tklauser deleted the pr/tklauser/renovate-nodeinit branch March 28, 2024 07:46
@joamaki joamaki mentioned this pull request Apr 2, 2024
Merged
8 tasks
@joamaki joamaki added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
Merged
10 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Apr 2, 2024
@joamaki joamaki mentioned this pull request Apr 2, 2024
Merged
13 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 2, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 4, 2024
@asauber asauber added affects/v1.14 This issue affects v1.14 branch and removed affects/v1.14 This issue affects v1.14 branch labels Apr 11, 2024
This was referenced Apr 11, 2024
Open
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@brlbil brlbil brlbil approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @gandro @brlbil @joamaki @asauber