testdata: minimize build output by reducing header includes #31644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralize the declaration so we can assume it's present in other Makefiles importing Makefile.defs. Signed-off-by: Timo Beckers <timo@isovalent.com>
This patch should make testdata play a bit nicer with backports, since including headers like node_config.h, ep_config.h and maps.h cause potential churn in the resulting BTF info. Include a minimal subset of headers and reduce testdata code to what's strictly necessary for the Go tests to run. Signed-off-by: Timo Beckers <timo@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
ti-mo
added
release-note/ci
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
bimmlerd
approved these changes
Mar 28, 2024
brlbil
approved these changes
Mar 28, 2024
rgo3
approved these changes
Mar 28, 2024
ldelossa
approved these changes
Mar 28, 2024
rolinh
approved these changes
Mar 28, 2024
4 tasks
ti-mo
added
backport-pending/1.15
rgo3
added
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should make testdata play a bit nicer with backports, since
including headers like node_config.h, ep_config.h and maps.h cause potential
churn in the resulting BTF info.
Include a minimal subset of headers and reduce testdata code to what's
strictly necessary for the Go tests to run.