Refactor InitK8sSubsystem and adding unit tests #31645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit bb86cfd does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
anubhabMajumdar
changed the title
github-actions
bot
added
the
kind/community-contribution
Signed-off-by: Anubhab Majumdar <anmajumdar@microsoft.com>
anubhabMajumdar
force-pushed
the
topic/anmajumdar/initk8ssubsystem
branch
from
bb86cfd
to
61060fe
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
joamaki
approved these changes
Apr 2, 2024
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
Signed-off-by: Anubhab Majumdar <anmajumdar@microsoft.com>
Addressed comments, thanks for the review :-) |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of the
InitK8sSubsystemfunction hardcodes the resources it will watch and sync. This is rather rigid and prevents development of effective unit-tests. Also, it's unclear from the function signature what exact resources are being watched/synced. Making this explicit will be helpful for the caller.In this change:
Fixes: N/A
Testing Done