Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update KPR value in ipsec upgrade jobs #31649

Merged
merged 1 commit into from Mar 28, 2024
Merged

test: Update KPR value in ipsec upgrade jobs #31649

merged 1 commit into from Mar 28, 2024

Conversation

sayboras
Copy link
Member

There is a merge race between the below two PRs, which leads to failure in CI job for ipsec upgrade config 5.15.

https://github.com/cilium/cilium/actions/runs/8461160283/job/23180526103

Error: Unable to upgrade Cilium: execution error at (cilium/templates/cilium-configmap.yaml:70:5): kubeProxyReplacement must be explicitly set to a valid value (true or false) to continue.

Relates: #31637, ##31637

There is a merge race between the below two PRs, which leads to failure
in CI job for ipsec upgrade config 5.15.

https://github.com/cilium/cilium/actions/runs/8461160283/job/23180526103
```
Error: Unable to upgrade Cilium: execution error at (cilium/templates/cilium-configmap.yaml:70:5): kubeProxyReplacement must be explicitly set to a valid value (true or false) to continue.
```

Relates: #31637, ##31637
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 28, 2024
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Mar 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 28, 2024
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review March 28, 2024 02:19
@sayboras sayboras requested review from a team as code owners March 28, 2024 02:19
@sayboras sayboras requested a review from pchaigno March 28, 2024 02:19
@sayboras sayboras enabled auto-merge March 28, 2024 03:07
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tam!

@sayboras sayboras added this pull request to the merge queue Mar 28, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 28, 2024
@pchaigno pchaigno added the feature/ipsec Relates to Cilium's IPsec feature label Mar 28, 2024
Merged via the queue into main with commit 458b5cc Mar 28, 2024
76 checks passed
@sayboras sayboras deleted the tam/fix-ci branch March 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ipsec Relates to Cilium's IPsec feature ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants