Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.14] gha: Enable Ingress Controller tests in conformance-e2e #31658

Merged
merged 1 commit into from Apr 9, 2024
Merged

[v1.14] gha: Enable Ingress Controller tests in conformance-e2e #31658

merged 1 commit into from Apr 9, 2024

Conversation

gandro
Copy link
Member

@gandro gandro commented Mar 28, 2024 •
edited

This is a manual backport of the following PRs to v1.14:

Once this PR is merged, a GitHub action will update the labels of these PRs:

 29130 30657

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Mar 28, 2024
@gandro gandro requested a review from sayboras March 28, 2024 13:40
@gandro gandro changed the title gha: Enable Ingress Controller tests in conformance-e2e [v1.14] gha: Enable Ingress Controller tests in conformance-e2e Mar 28, 2024
sayboras
sayboras approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤞

@gandro
Copy link
Member Author

gandro commented Mar 28, 2024

/ci-e2e

@gandro gandro marked this pull request as ready for review March 28, 2024 14:35
@gandro gandro requested review from a team as code owners March 28, 2024 14:35
@gandro gandro requested review from aanm and tklauser March 28, 2024 14:35
julianwiedmann
julianwiedmann approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ . Please add the blurb for the PR description to update the backport-labels.

@gandro
Copy link
Member Author

gandro commented Mar 28, 2024

@sayboras Workflow 6 failed: https://github.com/cilium/cilium/actions/runs/8468550882/job/23201850811

 ❌ 3/66 tests failed (3/953 actions), 9 tests skipped, 0 scenarios skipped:
Test [pod-to-ingress-service]:
  ❌ pod-to-ingress-service/pod-to-ingress-service/curl-2: cilium-test/client3-7557dd665c-9qkrd (10.244.1.254) -> cilium-test/cilium-ingress-ingress-service (cilium-ingress-ingress-service.cilium-test:80)
Test [pod-to-ingress-service-allow-ingress-identity]:
  ❌ pod-to-ingress-service-allow-ingress-identity/pod-to-ingress-service/curl-2: cilium-test/client3-7557dd665c-9qkrd (10.244.1.254) -> cilium-test/cilium-ingress-ingress-service (cilium-ingress-ingress-service.cilium-test:80)
Test [outside-to-ingress-service]:
  ❌ outside-to-ingress-service/outside-to-ingress-service/curl-ingress-service-0: cilium-test/host-netns-non-cilium-l258k (172.18.0.2) -> cilium-test/cilium-ingress-ingress-service (cilium-ingress-ingress-service.cilium-test:80)

As far as I can tell, it seems to be using the same configuration as v1.15, the only difference being the kernel version (6.0 vs 6.1). Is this expected?

@sayboras
Copy link
Member

sayboras commented Apr 3, 2024

As far as I can tell, it seems to be using the same configuration as v1.15, the only difference being the kernel version (6.0 vs 6.1). Is this expected?

I don't think it's due to kernel version differences, but probably related to one or two changes available in v1.15 but not backport to 1.14. I will need to dig a little bit further here.

@sayboras
Copy link
Member

sayboras commented Apr 8, 2024 •
edited

The above failure might take sometime to bisect, we can just skip it in this PR IMO.

I will raise one issue for workflow 6 + Ingress controller enabled (#31826)

This was referenced Apr 8, 2024
Open
Draft
@gandro
Copy link
Member Author

gandro commented Apr 8, 2024

Thanks a lot for looking into this 🙏 - I'll adjust the workflow accordingly.

@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
f4b4dbe 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro
Copy link
Member Author

gandro commented Apr 8, 2024

/test-backport-1.14

@gandro gandro requested a review from a team April 8, 2024 14:37
@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 8, 2024
@gandro
Copy link
Member Author

gandro commented Apr 8, 2024 •
edited

Needs review from current tophat for the button to be green, otherwise this is ready to merge

@lmb lmb merged commit bf6bf13 into v1.14 Apr 9, 2024
220 checks passed
@lmb lmb deleted the pr/gandro/ingress-in-e2e branch April 9, 2024 09:05
@asauber asauber mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmb lmb lmb approved these changes

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

@sayboras sayboras sayboras approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gandro @sayboras @lmb @tklauser @aanm @julianwiedmann