Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move governance docs to the Cilium community repo #31692

Merged
merged 1 commit into from Apr 9, 2024
Merged

Move governance docs to the Cilium community repo #31692

merged 1 commit into from Apr 9, 2024

Conversation

katiestruthers
Copy link
Contributor

@katiestruthers katiestruthers commented Mar 31, 2024 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

We are moving the governance docs out of the main Cilium repo and into the Cilium community repo. They are currently published in the community repo, and this PR will finish the move by deleting them from this main repo.

Changes includes deleting the governance docs from this location and updating the link to point to the governance docs in the new location.

Fixes: cilium/community#78

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 31, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 31, 2024
@katiestruthers
Copy link
Contributor Author

Please add the following label: area/documentation

@xmulligan xmulligan added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Apr 3, 2024
@xmulligan
Copy link
Member

I think you mean it fixes cilium/community#78

@katiestruthers katiestruthers marked this pull request as ready for review April 4, 2024 03:32
@katiestruthers katiestruthers requested review from a team as code owners April 4, 2024 03:32
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Apr 4, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 4, 2024
@bimmlerd
Copy link
Member

bimmlerd commented Apr 4, 2024

Hi, thank you for your contribution!

I think these changes are all related enough to live in a single commit, so could you squash them into one?

While at it, could you also add a description of the change and its motivation as the commit message? The PR description explains it well already, but it's not immediately available in the repo for developers, hence we prefer adding this context to the commit message.

lambdanis
lambdanis approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one suggestion, but don't consider it blocking. Thanks!

Documentation/community/governance.rst Outdated Show resolved Hide resolved
@lambdanis lambdanis added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 4, 2024
@lambdanis
Copy link
Contributor

Also I marked it for backports so that e.g. https://docs.cilium.io/en/v1.15/community/governance/ points to the community repo too.

@katiestruthers katiestruthers marked this pull request as draft April 5, 2024 03:00
@katiestruthers katiestruthers marked this pull request as ready for review April 5, 2024 03:00
bimmlerd
bimmlerd requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small mistake I missed on the first round, otherwise good to go!

CODEOWNERS Outdated Show resolved Hide resolved
@katiestruthers katiestruthers marked this pull request as draft April 6, 2024 16:16
@katiestruthers
Move governance docs to the Cilium Community repo
365cc54 
We are moving the governance docs out of the main Cilium repo and into the Cilium community repo. They are currently published in the community repo, and this commit will finish the move by deleting them from this main repo.

Changes includes deleting the governance docs from this location and updating links to point to the governance docs in the new location.

Fixes: cilium/community#78

Signed-off-by: Katie Struthers <99215338+katiestruthers@users.noreply.github.com>
@katiestruthers katiestruthers marked this pull request as ready for review April 6, 2024 16:25
@bimmlerd
Copy link
Member

bimmlerd commented Apr 8, 2024

/test

@bimmlerd
Copy link
Member

bimmlerd commented Apr 8, 2024 •
edited

/ci-ginkgo

CI triage:

@lmb lmb added this pull request to the merge queue Apr 9, 2024
Merged via the queue into cilium:main with commit 3847833 Apr 9, 2024
62 checks passed
@nbusseneau nbusseneau mentioned this pull request Apr 10, 2024
Merged
8 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 10, 2024
@nbusseneau nbusseneau mentioned this pull request Apr 10, 2024
Merged
9 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.15 Apr 10, 2024
@nbusseneau nbusseneau mentioned this pull request Apr 10, 2024
Merged
13 tasks
@nbusseneau nbusseneau added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.10 Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.4 Apr 10, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.4 Apr 11, 2024
@asauber asauber added this to Backport pending to v1.13 in 1.13.16 Apr 11, 2024
@asauber asauber removed this from Backport pending to v1.13 in 1.13.15 Apr 11, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Apr 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.10 Apr 11, 2024
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 17, 2024
@nebril nebril moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.16 May 10, 2024
@nebril nebril mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdanis lambdanis lambdanis approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@xmulligan xmulligan xmulligan approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.13.16
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Governance to the community repo
6 participants
@katiestruthers @xmulligan @bimmlerd @lambdanis @lmb @nbusseneau