route: Also compare ip rule mask for lookupRule #31700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jschwinger233
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
jschwinger233
added
the
sig/datapath
|
/test |
jschwinger233
force-pushed
the
gray/lookupRule
branch
from
186d2e5
to
dd988c7
Compare
|
/test |
markpash
approved these changes
Apr 3, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
it's |
jschwinger233
changed the title
|
@julianwiedmann Yeah 😨 I have to revise my commit message and re-run CI checks 😿 |
Previously lookupRule("fwmark 0xa00/0xe00 lookup 2005") doesn't work
when "fwmark 0xa00/0xf00 lookup 2005" is installed because lookupRule()
doesn't check rule mask. This commit fixes it.
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
gray/lookupRule
branch
from
dd988c7
to
f2873a1
Compare
julianwiedmann
approved these changes
Apr 3, 2024
|
The last push only touched the patch description, no code change. CI was green before -> merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously lookupRule("fwmark 0xa00/0xe00 lookup 2005") doesn't work when "fwmark 0xa00/0xf00 lookup 2005" is installed because lookupRule() doesn't check rule mask. This commit fixes it.