[v1.15] Author backport of #31493 #31739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, while translating K8s Ingress or Gateway API resources into Envoy resources, the virtualhosts aren't sorted. This leads to situations (especially in combination with Shared Ingress) where the order of the virtual hosts isn't guaranteed. Therefore, this commit orders the virtualhosts within a Envoy RouteConfiguration by their name. This influences the Envoy route matching process (https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/route_matching), but only by making it constant and not random. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/backports
|
/test-backport-1.15 |
julianwiedmann
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
🚀
Two process-related remarks:
- for non-trivial backports, we typically state somewhere in the PR or patch (as
backporter's notes) why the custom backport is needed, and what was altered. Here it looks like code was shuffled into different files between versions ...? - if you use the
upstream-prsannotation in the PR description, you'll get management of thebackport-donelabel for free :).
maintainer-s-little-helper
bot
added
the
ready-to-merge
mhofstetter
deleted the
pr/mhofstetter/ingress-cec-virtualhost-sorted-1.15
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, while translating K8s Ingress or Gateway API resources into Envoy resources, the virtualhosts aren't sorted. This leads to situations (especially in combination with Shared Ingress) where the order of the virtual hosts isn't guaranteed.
Therefore, this commit orders the virtualhosts within a Envoy RouteConfiguration by their name. This influences the Envoy route matching process (https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/route_matching), but only by making it constant and not random.
Backport of #31493 (Original PR changed the virtual host order in unit-tests that aren't present on v1.15)
Once this PR is merged, a GitHub action will update the labels of these PRs: