Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous nolint comments #31743

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Remove superfluous nolint comments #31743

merged 1 commit into from
Apr 3, 2024

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 3, 2024

The false positives of these being unused got fixed in recent linter releases and are no longer flagged in golangci-lint v1.57.1 which is currently used in main.

The false positives of these being unused got fixed in recent
linter releases and are no longer flagged in golangci-lint v1.57.1 which
is currently used in main.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Apr 3, 2024
@tklauser tklauser requested review from a team as code owners April 3, 2024 10:07
@tklauser
Copy link
Member Author

tklauser commented Apr 3, 2024

/test

@tklauser tklauser enabled auto-merge April 3, 2024 12:36
@tklauser tklauser added this pull request to the merge queue Apr 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 3, 2024
Merged via the queue into main with commit de131d7 Apr 3, 2024
232 of 233 checks passed
@tklauser tklauser deleted the pr/tklauser/rm-nolint branch April 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants