Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datapath: Move WG skb mark check to to-netdev #31751

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

brb
Copy link
Member

@brb brb commented Apr 3, 2024

This should not only improve the hot path performance, but also improve the code readability (an skb mark check is prefered to be closer to an entry function).

Suggested-by: Julian Wiedmann jwi@isovalent.com

@brb brb added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. labels Apr 3, 2024
This should not only improve the hot path performance, but also improve
the code readability (an skb mark check is preferred to be closer to an
entry function).

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/optimise-wg-check branch from 2895e6b to 7542a0d Compare April 3, 2024 13:51
@brb
Copy link
Member Author

brb commented Apr 3, 2024

/test

4.txt b/c we want to test with NodePort + EgressGW.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
Copy link
Member Author

brb commented Apr 3, 2024

/test

@brb brb marked this pull request as ready for review April 8, 2024 14:26
@brb brb requested review from a team as code owners April 8, 2024 14:26
@brb brb requested review from gandro and aspsk April 8, 2024 14:26
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks way better!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 8, 2024
@brb brb added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 0d72368 Apr 8, 2024
239 of 240 checks passed
@brb brb deleted the pr/brb/optimise-wg-check branch April 8, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants