Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove redundant IPsec test #31759

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 3, 2024

This test was made redundant by f153f42 ("workflows: Cover support for devices in IPsec tests"). Both the workflow cases from that commit and the ginkgo test removed here aim to cover support for IPsec decryption-handling in bpf_host (when --devices is specified).

@pchaigno pchaigno added area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. feature/ipsec Relates to Cilium's IPsec feature labels Apr 3, 2024
@pchaigno pchaigno requested review from a team as code owners April 3, 2024 22:12
@pchaigno pchaigno enabled auto-merge April 3, 2024 22:12
This test was made redundant by f153f42 ("workflows: Cover support
for devices in IPsec tests"). Both the workflow cases from that commit
and the ginkgo test removed here aim to cover support for IPsec
decryption-handling in bpf_host (when --devices is specified).

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the remove-redundant-ginkgo-test branch from eb21538 to 218710a Compare April 3, 2024 22:25
@pchaigno pchaigno requested a review from a team as a code owner April 3, 2024 22:25
@pchaigno
Copy link
Member Author

pchaigno commented Apr 3, 2024

/test

@pchaigno pchaigno changed the title test: Remove last IPsec test test: Remove redundant IPsec test Apr 3, 2024
@pchaigno pchaigno added this pull request to the merge queue Apr 4, 2024
Merged via the queue into cilium:main with commit a293e15 Apr 4, 2024
62 checks passed
@pchaigno pchaigno deleted the remove-redundant-ginkgo-test branch April 4, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. feature/ipsec Relates to Cilium's IPsec feature release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants