endpoint: skip Envoy incremental updates if no Envoy redirects (try 2) #31775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6888c64. This commit was not quite right, and should not have merged. There are cases where there are no pending policy-map changes, but there are pending Envoy ones. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
This should significantly reduce the amount of time it takes to roll out incremental policy updates by avoiding Envoy updates for endpoints which do not have any Envoy redirects. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
squeed
added
the
release-note/misc
|
/test |
jrajahalme
approved these changes
Apr 4, 2024
christarazi
added
area/daemon
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug introduced by #31454.
It removes the check that skips updating Envoy when there are no pending PolicyMap changes. This is because there are cases where endpoint regeneration will flush incremental changes, but not apply them to Envoy.
The basic flow is:
e.regenerate() -> e.updateNetworkPolicy()pushes policy to Envoye.regenerate() -> e.applyPolicyMapChanges()consumes incremental update but does not apply it to envoye.ApplyPolicyMapChanges()consumes incremental update, applies to envoyHowever, in this case, there is no pending incremental update for the BPF maps. The previous version of this code also skipped updating Envoy, which was incorrect.