Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: fix lock leases reporting in status #31781

Merged
merged 1 commit into from Apr 5, 2024
Merged

etcd: fix lock leases reporting in status #31781

merged 1 commit into from Apr 5, 2024

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Apr 4, 2024

Status was incorrectly reporting the number of generic leases twice, rather than generic and lock leases. Let's fix it.

Fixes: c6eb358 ("etcd: switch lock session to lease manager")

Fix incorrect reporting of the number of etcd lock leases in cilium-dbg status.

@giorio94
etcd: fix lock leases reporting in status
ada7091 
Status was incorrectly reporting the number of generic leases twice,
rather than generic and lock leases. Let's fix it.

Fixes: c6eb358 ("etcd: switch lock session to lease manager")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/kvstore Impacts the KVStore package interactions. needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 4, 2024
@giorio94 giorio94 requested a review from a team as a code owner April 4, 2024 16:25
@giorio94 giorio94 requested a review from marseel April 4, 2024 16:25
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.4 Apr 4, 2024
@giorio94
Copy link
Member Author

giorio94 commented Apr 4, 2024

/test

@giorio94
Copy link
Member Author

giorio94 commented Apr 5, 2024

Conformance EKS hit #30990

This was referenced Apr 5, 2024
Open
Closed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 5, 2024
@sayboras sayboras added this pull request to the merge queue Apr 5, 2024
Merged via the queue into cilium:main with commit 559eb5a Apr 5, 2024
63 checks passed
@nbusseneau nbusseneau mentioned this pull request Apr 10, 2024
Merged
13 tasks
@nbusseneau nbusseneau added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.4 Apr 10, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.4 Apr 11, 2024
@asauber asauber mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel marseel approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/kvstore Impacts the KVStore package interactions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giorio94 @marseel @nbusseneau @sayboras