Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: ct: clean up redundant 0-initializiations for CT entry creation #31788

Merged
merged 3 commits into from
Apr 5, 2024
Merged

bpf: ct: clean up redundant 0-initializiations for CT entry creation #31788

merged 3 commits into from
Apr 5, 2024

Conversation

julianwiedmann
Copy link
Member

Follow-up for 7abe5e7:

Note that this introduces a few additional explicit initializations of the
fields in ct_state, and we can potentially avoid some of them. But this
in-detail investigation is best done in a later patch.

Let's do this now :).

@julianwiedmann
bpf: lb: clean up CT_SERVICE entry creation
498f029 
ct_create_fill_entry() ignores the .proxy_redirect and .from_l7lb flags
for CT_SERVICE entries. Don't bother 0-initializing them.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: hostfw: clean up CT entry creation
08e2cd5 
The ct_state_new struct is 0-initialized, remove the additional
initialization for the .from_l7_lb field. While at it also move the struct
down into the code section that needs it.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: lxc: clean up CT entry creation
aab3b50 
The ct_state_new struct is 0-initialized, remove the additional
initialization for the .from_l7_lb field.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. feature/conntrack labels Apr 5, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title bpf: ct: clean up redundant 0-initializiations for ct_state bpf: ct: clean up redundant 0-initializiations for CT entry creation Apr 5, 2024
@julianwiedmann julianwiedmann marked this pull request as ready for review April 5, 2024 09:05
@julianwiedmann julianwiedmann requested a review from a team as a code owner April 5, 2024 09:05
@julianwiedmann
Copy link
Member Author

(CI is still recovering from the GH outage)

aspsk
aspsk approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one cosmetic comment

bpf/lib/host_firewall.h Show resolved Hide resolved
@julianwiedmann
Copy link
Member Author

/ci-aks

@julianwiedmann
Copy link
Member Author

/ci-e2e

@julianwiedmann
Copy link
Member Author

/ci-gke

@julianwiedmann
Copy link
Member Author

/ci-clustermesh

@julianwiedmann
Copy link
Member Author

/ci-integration

@julianwiedmann julianwiedmann reopened this Apr 5, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 5, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Apr 5, 2024
Merged via the queue into cilium:main with commit 88855db Apr 5, 2024
105 checks passed
@julianwiedmann julianwiedmann deleted the 1.16-bpf-ct-flags-cleanup branch April 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
feature/conntrack kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianwiedmann @aspsk