loader: remove CompileAndLoad #31792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
added
sig/loader
|
/test |
lmb
force-pushed
the
pr/lmb/remove-compile-and-load
branch
2 times, most recently
from
0b175a3
to
dca9971
Compare
|
/test |
Endpoint calls into the loader in different "modes", depending on
how much the configuration has changed.
1. ReloadDatapath: re-attach programs without compiling them.
2. CompileOrLoad: re-attach a program, possibly retrieving it
a cache.
3. CompileAndLoad: re-attach a program without retrieving it
from cache.
CompileAndLoad does completely bypass the cache, but at the same
time doesn't invalidate it. The following sequence of calls would
therefore reuse an old (cached) program:
CompileOrLoad()
CompileAndLoad()
CompileOrLoad() // back to the cached program from above
According to Joe Stringer, CompileAndLoad mode was meant as an
escape hatch to debug caching bugs. This never really materialised
so we can simplify the loader by removing the code path outright.
Tests for CompileAndLoad are simply changed to call CompileOrLoad.
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Use require.Error and require.NoError instead of the Nil variants. This leads to more readable error messages. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
force-pushed
the
pr/lmb/remove-compile-and-load
branch
from
dca9971
to
9e581ec
Compare
|
/test |
rgo3
approved these changes
Apr 19, 2024
aditighag
approved these changes
Apr 22, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loader: remove unused CompileAndLoad mode
loader: use require helpers for errors